[Letux-kernel] [PATCH v3 4/4] DTS: Pandora: fix panel compatibility string

H. Nikolaus Schaller hns at goldelico.com
Tue Nov 28 19:32:37 CET 2017


Hi,

> Am 28.11.2017 um 17:18 schrieb Tony Lindgren <tony at atomide.com>:
> 
> * H. Nikolaus Schaller <hns at goldelico.com> [171128 16:17]:
>> Hi Tony,
>> 
>>> Am 28.11.2017 um 17:04 schrieb Tony Lindgren <tony at atomide.com>:
>>> 
>>> * H. Nikolaus Schaller <hns at goldelico.com> [171128 15:52]:
>>>> We can remove the unnecessary "omapdss," prefix because
>>>> the omapdrm driver takes care of it when matching with
>>>> the driver table.
>>> 
>>> So is this needed as a fix or is this another clean-up?
>>> 
>>> So is this is really needed as a fix?
>> 
>> Hm. How do you differentiate between "fix" and "cleanup"?
>> Maybe it is more a wording than a content issue...
>> 
>> For me it is a "fix" because it is semantically wrong to have
>> a prefix where it is not needed. And "fixing" it changes the
>> compiler output by 8 bytes.
> 
> How about let's call it a "typo fix" then? :)

Well, it is not really a typo.

> 
>> "Cleanup" would be for me removing whitespace or empty lines
>> or typos in comments.
>> 
>>> If this is just clean-up, again, please resend once the driver
>>> changes have cleared.
>> 
>> There is no change to the pandora driver involved here. The Pandora
>> panel driver is already correct. Just the DTS has some redundant
>> content which should be removed.
>> 
>> So there is no dependency for this patch.
> 
> OK please resend separately after the driver changes have merged
> then.

The Pandora driver does not need an update. Only the DTS.
So there is noting to merge or wait for.

Maybe the confusion comes that in both cases (GTA04 and OpenPandora)
there are changes to DTS.

But different ones.

GTA04: change vendor prefix to make it consistent
Pandora: remove redundant (unnecessary and potentially wrong) omapdss, prefix

In addition we have to modify the GTA04 panel to handle the correct
vendor prefix. The Pandora panel already uses the right one.

Anyways, I think it is now Tomi to decide about the panel driver
(vendor prefix) patch 1/4 and 2/4 first. Then we can sort out
the DTS changes (3/4 and 4/4).

BR and thanks,
Nikolaus



More information about the Letux-kernel mailing list