[Letux-kernel] [PATCH v6 7/8] drivers:input:ads7846(+tsc2046): fix spi module table

Javier Martinez Canillas javier at osg.samsung.com
Wed Nov 23 14:12:06 CET 2016


Hello Dmitry,

On 11/19/2016 03:18 PM, Dmitry Torokhov wrote:
> On Thu, Oct 27, 2016 at 10:44:20AM +0200, H. Nikolaus Schaller wrote:
>> Fix module table so that the driver is loaded if compiled
>> as module and requested by DT.
> 
> We really need to fix it between spi/i23c core and module utils instead
> of keeping adding duplicate IDs all over drivers. We already have OF
> module device table containing the same data, we should be able to use
> it.
> 

Agreed, unfortunately until the I2C and SPI core are changed to properly
report OF modaliases, we will have to keep adding these duplicated IDs.

And changing the I2C and SPI core isn't trivial since it could break a
lot of drivers that rely on a platform modalias being reported (i.e: no
OF device IDs present in the drivers even when are registered via DT).

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America


More information about the Letux-kernel mailing list